Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cosmos to ledger #659

Merged
merged 3 commits into from
Jan 22, 2024
Merged

feat: add cosmos to ledger #659

merged 3 commits into from
Jan 22, 2024

Conversation

kaladinlight
Copy link
Contributor

No description provided.

@kaladinlight kaladinlight requested a review from a team as a code owner January 22, 2024 20:57
Copy link

vercel bot commented Jan 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hdwallet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 11:32pm

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally:

Accounts add is happy

Screenshot 2024-01-22 at 22 04 11

Accounts are happy and the same as native on develop

Screenshot 2024-01-22 at 22 06 23

Self-send is happy

image

gomesalexandre
gomesalexandre previously approved these changes Jan 22, 2024
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-stamp for when CI will be happy

@kaladinlight kaladinlight merged commit 2209e26 into master Jan 22, 2024
6 checks passed
@kaladinlight kaladinlight deleted the ledger-cosmos branch January 22, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants